Skip to content

Conversation

@big-r81
Copy link

@big-r81 big-r81 commented Oct 17, 2025

Adding SpiderMonkey v128 as additional version

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula rust Rust use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Oct 17, 2025
@daeho-ro
Copy link
Member

daeho-ro commented Oct 17, 2025

Why do we need this specific version?

It's already in EOL.

@big-r81
Copy link
Author

big-r81 commented Oct 17, 2025

In CouchDB we embedding SpiderMonkey, but we are not ready to use v140 yet, because there are again additional API internal changes ...

@daeho-ro
Copy link
Member

daeho-ro commented Oct 17, 2025

Homebrew version of couchdb also disable spidermonkey... Do you have any plan for enable it?

system "./configure", "--disable-spidermonkey", "--js-engine=quickjs"

@big-r81
Copy link
Author

big-r81 commented Oct 17, 2025

We are on the way of deprecating spidermonkey (no official decission yet) and a possible replace candidate is QuickJS. For developing, we still use SpiderMonkey, but not yet v140.

@daeho-ro daeho-ro added the maintainer feedback Additional maintainers' opinions may be needed label Oct 18, 2025
@daeho-ro daeho-ro marked this pull request as draft October 18, 2025 07:23
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Adding SpiderMonkey v128 as additional version
@daeho-ro daeho-ro force-pushed the big-r81-spidermonkey-v128 branch from 501ac61 to d9650e3 Compare October 23, 2025 08:00
@p-linnane
Copy link
Member

We don't accept things that are already EOL.

@p-linnane p-linnane closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants