Skip to content

Conversation

@daeho-ro
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 01:53
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the otterdog formula to use Python 3.14, updating dependencies and resource versions accordingly. The migration includes significant dependency management changes to ensure proper builds with the newer Python version.

Key Changes

  • Migrated from [email protected] to [email protected] as the primary dependency
  • Moved several dependencies (certifi, cryptography, rpds-py) to no_linkage mode and added them to the exclude packages list
  • Updated Python resource versions for dependencies including aiohttp, click, attrs, and several others

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Formula/o/otterdog.rb Migrated to Python 3.14; reorganized dependencies with no_linkage flags; updated all Python resource versions; moved playwright resource definition; removed obsolete resources (greenlet, pyee, rpds-py, typing-extensions)
pypi_formula_mappings.json Added playwright and rpds-py to the exclude packages list for otterdog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@daeho-ro daeho-ro marked this pull request as draft October 21, 2025 11:22
@daeho-ro daeho-ro marked this pull request as ready for review October 21, 2025 11:34
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2025
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 21, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 21, 2025 13:04
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit b4cc029 Oct 21, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the otterdog-python branch October 21, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python-3.14-migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants