Update csidriver.yaml spec #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per VPC file csi driver use case, we require the k8s to update the ownership of volume via fsGroup in case the volume is used by an application running as non root.
|
👍 Coverage increased from [%] to [81.8125%] |
ambiknai
reviewed
Mar 20, 2024
There was a problem hiding this comment.
@prankulmahajan Is this capability added in code?
CSI drivers that support this feature should advertise the [VOLUME_MOUNT_GROUP](https://github.com/container-storage-interface/spec/blob/master/spec.md#nodegetcapabilities) node capability.
After recognizing this information, the kubelet passes the fsGroup information to the CSI driver during pod startup. This is done through the [NodeStageVolumeRequest](https://github.com/container-storage-interface/spec/blob/v1.7.0/spec.md#nodestagevolume) and [NodePublishVolumeRequest](https://github.com/container-storage-interface/spec/blob/v1.7.0/spec.md#nodepublishvolume) CSI calls.
This capilility was added for drivers which support option to pass fsGroup as mount option during mount. But in IBM case that is not there. So we cannot delegate the fsGroup changes to CSI driver but rather have to rely on kubelet to do that us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per VPC file csi driver use case, we require the k8s to update the ownership of volume via fsGroup in case the volume is used by an application running as non root.