Skip to content

Conversation

77web
Copy link
Contributor

@77web 77web commented Oct 9, 2024

Hi, signRegion for far east region is us-west-2 not eu-west-1.
https://developer.amazon.com/docs/incentives-api/incentives-api.html#endpoints

We need valid signRegion for far east endpoint.
Thanks in advance.

@stof stof force-pushed the main branch 2 times, most recently from e36fe22 to a1225b7 Compare October 11, 2024 17:08
@stof
Copy link
Member

stof commented Oct 11, 2024

Thanks for catching this, and sorry for the mistake (as you can guess, our own usage at Incenteev does not use that region).

However, modifying this method directly is the wrong way to fix it as it is part of the code generated using async-aws/code-generator. Instead, the value must be modified in the manifest file (manifest/endpoints.json in this case) and the code regenerated by using ./generate --all.

Sorry for not having contribution guidelines about that. I did not really expect receiving external contributions for that package so I haven't written them yet. It is nice to know that this package is benefiting others though (that's the reason we open-sourced it instead of keeping it as a private package).

@77web
Copy link
Contributor Author

77web commented Oct 12, 2024

@stof
Thank you!
I've updated manifest and executed generate 😃

@stof
Copy link
Member

stof commented Oct 14, 2024

Thank you @77web.

@stof stof merged commit e45113a into Incenteev:main Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants