Auto-retry failed connection #223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement what is necessary to retry a failed connection (for reasons such as, for exemple, not being connection to internet on when rescrobbled start).
I have implemented exponentional back-off, it will retry every 15 minutes as worst.
An evolution I foresee is not retrying when we got the confirmation the token or configuration is invalid.
It moved the old "Service" into a "ServiceConnection" trait with two implementation (for ListenBrainz and Last.fm). The new "Service" overlay over them to persist information about them even in case of a failed initial connection.
I only tried with ListenBrainz. I would like someone to try with Last.fm. I’m a bit worried of how it would work with the initial last.fm connection system (before obtaining a token).
Fix #222