Skip to content

Extension of the Fawe documentation to achieve a better understanding of regions and patterns #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Extension of the Fawe documentation to achieve a better understanding of regions and patterns #65

wants to merge 7 commits into from

Conversation

TheMeinerLP
Copy link
Member

Overview

Description

The pull request is dedicated to new developers who plan to edit regions with different patterns and execute code from Fawe async. This PR also covers the Biome pattern and the Cubiod region. It also deals with the FAWE TaskManager and the Spigot scheduler

### Submitter Checklist
- [X] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [X] Ensure that the pull request title represents the desired changelog entry.
- [X] New public fields and methods are annotated with `@since TODO`.
- [X] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner February 8, 2024 08:50
@NotMyFault
Copy link
Contributor

The PR conflicts, please rebase with the main branch.

@TheMeinerLP TheMeinerLP force-pushed the feature/advance-fawe-developer-examples branch from 6a4cd97 to ab9333f Compare February 9, 2024 09:27
@TheMeinerLP
Copy link
Member Author

Conflicts resolved

@NotMyFault
Copy link
Contributor

I'd like to request an explicit review of @SirYwell and @dordsor21, given you have a more profound understanding of me about this topic.

PierreSchwang
PierreSchwang reviewed Feb 9, 2024
View reviewed changes
SirYwell
SirYwell requested changes Feb 9, 2024
View reviewed changes
@OneLiteFeather OneLiteFeather added documentation Improvements or additions to documentation FastAsyncWorldEdit labels Feb 9, 2024
@TheMeinerLP TheMeinerLP requested a review from SirYwell February 9, 2024 11:59
@TheMeinerLP TheMeinerLP force-pushed the feature/advance-fawe-developer-examples branch from ae0e4a8 to a9b19eb Compare February 9, 2024 12:08
@NotMyFault
Copy link
Contributor

If someone from @IntellectualSites/fastasyncworldedit-team want to take another look :)

PierreSchwang
PierreSchwang requested changes Mar 31, 2024
View reviewed changes
@TheMeinerLP TheMeinerLP force-pushed the feature/advance-fawe-developer-examples branch from 6774509 to f28aea7 Compare April 7, 2024 12:32
@TheMeinerLP TheMeinerLP requested review from a team as code owners April 7, 2024 12:32
@TheMeinerLP TheMeinerLP force-pushed the feature/advance-fawe-developer-examples branch from f28aea7 to f61a059 Compare April 7, 2024 12:33
@TheMeinerLP
Add some small example for patter usage inside of the worldedit.
c2c2c67 
This example describe so far it possible the edit process and the async process to edit a region with a specific biome.
@TheMeinerLP TheMeinerLP force-pushed the feature/advance-fawe-developer-examples branch from f61a059 to c2c2c67 Compare April 7, 2024 12:37
SirYwell
SirYwell requested changes Apr 7, 2024
View reviewed changes
@TheMeinerLP TheMeinerLP requested a review from SirYwell April 7, 2024 18:20
OneLiteFeather
OneLiteFeather approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@OneLiteFeather OneLiteFeather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneLiteFeather
Copy link
Member

@TheMeinerLP reminder to rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneLiteFeather OneLiteFeather OneLiteFeather approved these changes

@dordsor21 dordsor21 Awaiting requested review from dordsor21

@PierreSchwang PierreSchwang Awaiting requested review from PierreSchwang

@SirYwell SirYwell Awaiting requested review from SirYwell

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation FastAsyncWorldEdit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheMeinerLP @NotMyFault @OneLiteFeather @SirYwell @PierreSchwang