Modular v3 #115
Draft
Modular v3 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * wip * wip * wip * Move config * Delete Cache.php * Code style * Improve event auto-discovery * Update phpunit.yml * Remove unnecessary 'getCachePath' * Code style * Update phpunit.yml * Update actions * debug * More debugging * Update phpunit.yml
skylerkatz
approved these changes
Mar 20, 2025
|
This is HUGE! I'm particularly excited for the module caching (much needed to improve performance)---any idea on when this will be released? Would love to help out if needed! |
calebdw
reviewed
May 19, 2025
Comment on lines
+78
to
+81
| Artisan::starting(function(Artisan $artisan) { | ||
| $this->autodiscover()->commands($artisan); | ||
| $this->registerNamespacesInTinker(); | ||
| }); |
There was a problem hiding this comment.
I would recommend that the modules:cache command be added to the optimize command:
Suggested change
| Artisan::starting(function(Artisan $artisan) { | |
| $this->autodiscover()->commands($artisan); | |
| $this->registerNamespacesInTinker(); | |
| }); | |
| Artisan::starting(function(Artisan $artisan) { | |
| $this->autodiscover()->commands($artisan); | |
| $this->registerNamespacesInTinker(); | |
| }); | |
| $this->optimizes('modules:cache', 'modules:clear', 'modules'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature branch for the v3 release of modular. v3 should be mostly backwards-compatible, but will drop support for some older Laravel/PHP versions and update some internals.