Convert Lit-analyzer CLI to ESM #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df2021e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally broke the CLI as part of upgrading the
chalkpackage (version 5 is pure ESM). Switching the CLI to ESM also gets it working properly again, without needing to downgrade thechalkdependency.The CLI export is also now separate from the rest of the
lit-analyzerpackage, and so won't be included as part of the defaultindex.jsfile.I will try to look at adding some tests around the CLI tool soon, to prevent this sort of regression from happening in the future.
Unfortunately, I don't believe that it is possible to upgrade the rest of the packages to ESM yet. I explored this work in this other PR, but until VSCode supports ESM dependencies that work is blocked.