Add Create Release Job #374
Conversation
Co-authored-by: Denis <[email protected]>
Co-authored-by: Denis <[email protected]>
jonkoops
left a comment
jonkoops
left a comment
There was a problem hiding this comment.
Couple of notes:
- I think we can put all the work in a single job (under
publish) - Getting the version of the package should be possible locally, using
npm pkg get version | xargsorcat package.json | jq -r '.version'. This also prevents issues when we're releasing patches for older versions, rather than just thelatesttag.
|
I've made some improvements but could not quite test it well. I will double check on this tomorow or this weekend if changes are needed. |
| NPM_CONFIG_PROVENANCE: true | ||
|
|
||
| - name: Create GitHub Release | ||
| run: gh release create ${{ steps.get_version.outputs.version }} --title ${{ steps.get_version.outputs.version }} --notes "Full changelog at https://github.com/JedWatson/classnames/blob/main/CHANGELOG.md" |
There was a problem hiding this comment.
Here there is a reference to a step with the id get_version, but looks like the package version step is missing that id.
| NPM_CONFIG_PROVENANCE: true | ||
|
|
||
| - name: Create GitHub Release | ||
| run: gh release create ${{ steps.get_version.outputs.version }} --title ${{ steps.get_version.outputs.version }} --notes "Full changelog at https://github.com/JedWatson/classnames/blob/main/CHANGELOG.md" |
There was a problem hiding this comment.
Thinking that we might want to use the current commit rather than main, so that the relevant notes for that release are always on top. WDYT?
There was a problem hiding this comment.
Sounds good I'll try to add this feature. By the way sorry for the late responses the work has been pretty heavy these few weeks.
There was a problem hiding this comment.
No worries, I also maintain this stuff in my spare time, so I know the pain 😉
There was a problem hiding this comment.
I don't think it is a good idea to use the current commit as if the CHANGELOG did not get updated with that commit it would be empty so I thought linking the main branches CHANGELOG would be a better idea.
There was a problem hiding this comment.
I don't think it is a good idea to use the current commit as if the CHANGELOG did not get updated with that commit
That's ok. I always update the changelog before release. In the future I'd like to automate this proccess also.
| run: | | ||
| VERSION=$(npm pkg get version | xargs) | ||
| echo "Package version is $VERSION" | ||
| echo "::set-output name=version::$VERSION" |
There was a problem hiding this comment.
| echo "::set-output name=version::$VERSION" | |
| echo "name=$VERSION" >> $GITHUB_OUTPUT |
4 participants
Related to #372
Me and @0xD3n worked on creating this pipeline.