Adds shell protocol support #239
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello @JeffLIrion ! I've been making use of your adb-shell project (thanks for the work on that), and realized there was a feature I could really use. It seems like others are looking for this change as well, and I thought instead of just asking for it to be done, I'd try offering a contribution via a PR:
This PR adds support for making use of the newer "shell protocol" service which can return separate stdout/stderr streams, as well as return exit code information from the shell.
Changes Made
Here is what it looks like in action:
Related Issue
Addresses #217
Checklist
Do you think this is a candidate for getting merged to adb-shell main? It would extremely useful for me, if it could get merged/tagged (in some form or another.) Open to any suggestions/changes you would have.