Skip to content

fix single-Colon getindex #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

fix single-Colon getindex #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb29b0
fix single-Colon `getindex`
nsajko Oct 15, 2025
aab59fd
relax method signature again, handle all ndims correctly
nsajko Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/FixedSizeArray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,12 @@ end
# `getindex` with a `Colon` for the index: better effects than with the generic fallback

function Base.getindex(a::FixedSizeArray, ::Colon)
copy(a)
c = copy(a)
if a isa AbstractVector
c
else
reshape(c, :)
end
end

# `copyto!`
Expand Down
11 changes: 10 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ end
m = FixedSizeArray(rand(2, 2))::FixedSizeArray
@test m == copy(m)
@test m !== copy(m)
@test m == m[:]
@test reshape(m, :) == m[:]
@test m !== m[:]
end

Expand Down Expand Up @@ -708,4 +708,13 @@ end
tuple(m...)
end[] == NTuple{3, Int}
end

@testset "getindex with a single colon must return an `AbstractVector`" begin
for m in 0:3
@test let a = FixedSizeArray{Float32}(undef, ntuple(Returns(1), m))
a::AbstractArray{<:Any, m}
a[:] isa AbstractVector
end
end
end
end