- 
                Notifications
    
You must be signed in to change notification settings  - Fork 502
 
          Adds an options to use listings for code highlighting in LaTeX
          #2349
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
listings for code highlighting in LaTeX
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks fine. Code needs a few cleanup things, and I would love to get the showcase build with listings passing on CI before merging.
| 
           @mortenpi I really did not have time to push this further so far... What can I do to revive this ?  | 
    
| 
           @BambOoxX to revive this, the first step would be to resolve the merge conflicts that accumulated over time. Then CI has a chance to run and we can see if tests pass.  | 
    
| 
               | 
          ||
| % defining the jlcode package | ||
| \def\fileversion{6.1} | ||
| \def\filedate{2022/05/03} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the top of the file the copyright is only listed as 2018, here it says 2022...?!
| @@ -0,0 +1,2247 @@ | |||
| %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% | |||
| %%% | |||
| %%% jlcode.sty | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a home repository for this style file? Or some other source we can list?
eae1d75    to
    1c01deb      
    Compare
  
    | 
           OK, I overhauled this PR: first squashed everything into a single commit based on the merge-base commit with master. Then remove most of the   | 
    
| examples_latex_texonly_doc = if "latex_texonly" in EXAMPLE_BUILDS | ||
| @info("Building mock package docs: LaTeXWriter/latex_texonly") | ||
| @quietly makedocs( | ||
| makedocs( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this was removed for debugging but should be added back before merging?
| makedocs( | |
| @quietly makedocs( | 
| 
               | 
          ||
| examples_latex_listings_texonly_doc = if "latex_listings_texonly" in EXAMPLE_BUILDS | ||
| @info("Building mock package docs: LaTeXWriter/latex_listings_texonly") | ||
| makedocs( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| makedocs( | |
| @quietly makedocs( | 
... so that we can run those tests with `warnonly = false`, at least in some specific Julia versions.
ec37ed6    to
    3ceab35      
    Compare
  
    3ceab35    to
    6fbcc31      
    Compare
  
    
Fixes #2309