Skip to content

Conversation

@BambOoxX
Copy link

@BambOoxX BambOoxX commented Nov 16, 2023

Fixes #2309

@mortenpi mortenpi changed the title 2309 listings Adds an options to use listings for code highlighting in LaTeX Dec 2, 2023
@mortenpi mortenpi added Type: Enhancement Format: LaTeX Related to the LaTeX / PDF output labels Dec 2, 2023
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks fine. Code needs a few cleanup things, and I would love to get the showcase build with listings passing on CI before merging.

@BambOoxX
Copy link
Author

BambOoxX commented Dec 1, 2024

@mortenpi I really did not have time to push this further so far... What can I do to revive this ?

@fingolfin
Copy link
Collaborator

@BambOoxX to revive this, the first step would be to resolve the merge conflicts that accumulated over time. Then CI has a chance to run and we can see if tests pass.


% defining the jlcode package
\def\fileversion{6.1}
\def\filedate{2022/05/03}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the top of the file the copyright is only listed as 2018, here it says 2022...?!

@@ -0,0 +1,2247 @@
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%
%%% jlcode.sty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a home repository for this style file? Or some other source we can list?

@fingolfin
Copy link
Collaborator

OK, I overhauled this PR: first squashed everything into a single commit based on the merge-base commit with master. Then remove most of the settings=... bits (they just cause merge conflicts); and merged master. It could be squashed once again into a single commit if desired. I also removed several gratuitous changes (e.g. we have to check for latexmk not pdflatex because we actually call latexmk)

examples_latex_texonly_doc = if "latex_texonly" in EXAMPLE_BUILDS
@info("Building mock package docs: LaTeXWriter/latex_texonly")
@quietly makedocs(
makedocs(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was removed for debugging but should be added back before merging?

Suggested change
makedocs(
@quietly makedocs(


examples_latex_listings_texonly_doc = if "latex_listings_texonly" in EXAMPLE_BUILDS
@info("Building mock package docs: LaTeXWriter/latex_listings_texonly")
makedocs(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
makedocs(
@quietly makedocs(

... so that we can run those tests with `warnonly = false`,
at least in some specific Julia versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Format: LaTeX Related to the LaTeX / PDF output Type: Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch or at least support code listings in LaTeX using the listings package instead of minted

3 participants