Skip to content

Conversation

@fingolfin
Copy link
Collaborator

For the MathOptInterface.jl failure, see jump-dev/MathOptInterface.jl#2877 (CC @odow)

@fingolfin fingolfin added the Skip Changelog Allows the CHANGELOG.md check to pass without edit to the file. label Nov 1, 2025
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of curiosity, what's up with Oscar that this is necessary? How does it depend on Hecke (and friends?) without it being the docs dep?

@fingolfin
Copy link
Collaborator Author

Part of the problem is that Oscar's manual actually contains parts of the Hecke/Nemo/AbstractAlgebra manuals, which we currently have to copy over in a somewhat hackish process (we are still looking for better solutions). And the packages are tightly interlinked: so when people work on stuff, they often need to have devel'ed versions of all packages together in an environment. When building the docs those versions must be matched, so the build script develops them all into the docs environment.

Overall, the docs/Project.toml should IMO really have Hecke, Nemo etc. in it, but it currently hasn't; this is because we run into some annoying corner cases in how Pkg.jl works in the past that caused pain, so we removed them.

All that said, I hope we can revise this setup in Oscar in the not-so-distant future to be a bit less hackish, and then the change in this PR can be reverted. But for the currently released version, it is necessary.

@fingolfin fingolfin merged commit 1e9e0cc into master Nov 3, 2025
37 of 38 checks passed
@fingolfin fingolfin deleted the mh/oscar-regression-tests branch November 3, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allows the CHANGELOG.md check to pass without edit to the file. Type: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants