Debug ci hangs #377
Open
Debug ci hangs #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
===========================================
+ Coverage 31.39% 80.05% +48.65%
===========================================
Files 11 12 +1
Lines 672 722 +50
===========================================
+ Hits 211 578 +367
+ Misses 461 144 -317 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
christiangnrd
force-pushed
the
patch-3
branch
3 times, most recently
from
fc50390 to
a100e78
Compare
christiangnrd
force-pushed
the
patch-3
branch
from
425ed4a to
6140c53
Compare
christiangnrd
force-pushed
the
patch-3
branch
from
7b5af2a to
9e633c7
Compare
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/intrinsics.jl b/test/intrinsics.jl
index c2494d0..6b15ec2 100644
--- a/test/intrinsics.jl
+++ b/test/intrinsics.jl
@@ -15,28 +15,28 @@ const ispocl = cl.platform().name == "Portable Computing Language"
@testset "intrinsics" begin
@testset "barrier" begin
-@time "Barrier Local Mem fence" @on_device barrier(OpenCL.LOCAL_MEM_FENCE)
-@time "Barrier global Mem fence" @on_device barrier(OpenCL.GLOBAL_MEM_FENCE)
-@time "Barrier both Mem fence" @on_device barrier(OpenCL.LOCAL_MEM_FENCE | OpenCL.GLOBAL_MEM_FENCE)
+ @time "Barrier Local Mem fence" @on_device barrier(OpenCL.LOCAL_MEM_FENCE)
+ @time "Barrier global Mem fence" @on_device barrier(OpenCL.GLOBAL_MEM_FENCE)
+ @time "Barrier both Mem fence" @on_device barrier(OpenCL.LOCAL_MEM_FENCE | OpenCL.GLOBAL_MEM_FENCE)
-@time "WorkGroup Barrier Local Mem fence" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE)
-@time "WorkGroup Barrier global Mem fence" @on_device work_group_barrier(OpenCL.GLOBAL_MEM_FENCE)
-@time "WorkGroup Barrier image Mem fence" @on_device work_group_barrier(OpenCL.IMAGE_MEM_FENCE)
+ @time "WorkGroup Barrier Local Mem fence" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE)
+ @time "WorkGroup Barrier global Mem fence" @on_device work_group_barrier(OpenCL.GLOBAL_MEM_FENCE)
+ @time "WorkGroup Barrier image Mem fence" @on_device work_group_barrier(OpenCL.IMAGE_MEM_FENCE)
-@time "WorkGroup Barrier L/G Mem fence" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE | OpenCL.GLOBAL_MEM_FENCE)
-@time "WorkGroup Barrier L/I Mem fence" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE | OpenCL.IMAGE_MEM_FENCE)
-@time "WorkGroup Barrier L/G/I Mem fence" @on_device work_group_barrier(OpenCL.GLOBAL_MEM_FENCE | OpenCL.LOCAL_MEM_FENCE | OpenCL.IMAGE_MEM_FENCE)
+ @time "WorkGroup Barrier L/G Mem fence" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE | OpenCL.GLOBAL_MEM_FENCE)
+ @time "WorkGroup Barrier L/I Mem fence" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE | OpenCL.IMAGE_MEM_FENCE)
+ @time "WorkGroup Barrier L/G/I Mem fence" @on_device work_group_barrier(OpenCL.GLOBAL_MEM_FENCE | OpenCL.LOCAL_MEM_FENCE | OpenCL.IMAGE_MEM_FENCE)
-@time "WorkGroup Barrier Local Mem fence, work item scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_work_item)
-@time "WorkGroup Barrier Local Mem fence, workgroup scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_work_group)
-@time "WorkGroup Barrier Local Mem fence, device scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_device)
-@time "Skipped" cl.memory_backend() isa cl.SVMBackend && @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_all_svm_devices)
-@time "WorkGroup Barrier Local Mem fence, subgroup scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_sub_group)
+ @time "WorkGroup Barrier Local Mem fence, work item scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_work_item)
+ @time "WorkGroup Barrier Local Mem fence, workgroup scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_work_group)
+ @time "WorkGroup Barrier Local Mem fence, device scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_device)
+ @time "Skipped" cl.memory_backend() isa cl.SVMBackend && @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_all_svm_devices)
+ @time "WorkGroup Barrier Local Mem fence, subgroup scope" @on_device work_group_barrier(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_scope_sub_group)
end
@testset "mem_fence" begin
-@warn "mem_fence"
+ @warn "mem_fence"
@on_device mem_fence(OpenCL.LOCAL_MEM_FENCE)
@on_device mem_fence(OpenCL.GLOBAL_MEM_FENCE)
@@ -53,7 +53,7 @@ end
end
@testset "atomic_work_item_fence" begin
-@warn "atomic_work_item_fence"
+ @warn "atomic_work_item_fence"
@on_device atomic_work_item_fence(OpenCL.LOCAL_MEM_FENCE, OpenCL.memory_order_relaxed, OpenCL.memory_scope_work_item)
@on_device atomic_work_item_fence(OpenCL.GLOBAL_MEM_FENCE, OpenCL.memory_order_acquire, OpenCL.memory_scope_work_group)
@@ -65,7 +65,7 @@ cl.memory_backend() isa cl.SVMBackend && @on_device atomic_work_item_fence(OpenC
end
@testset "math" begin
-@warn "math"
+ @warn "math"
@testset "unary - $T" for T in float_types
@testset "$f" for f in [
@@ -103,7 +103,7 @@ end
hypot,
(^),
]
- @warn "binary - $T, $f"
+ @warn "binary - $T, $f"
x = rand(T)
y = rand(T)
broken = ispocl && T == Float16 && f == atan
@@ -115,7 +115,7 @@ end
@testset "$f" for f in [
fma,
]
- @warn "ternary - $T, $f"
+ @warn "ternary - $T, $f"
x = rand(T)
y = rand(T)
z = rand(T)
@@ -132,7 +132,7 @@ end
OpenCL.rint,
OpenCL.rsqrt,
]
- @warn "OpenCL-specific unary - $T, $f"
+ @warn "OpenCL-specific unary - $T, $f"
x = rand(T)
broken = ispocl && T == Float16 && !(f in [OpenCL.rint, OpenCL.rsqrt])
@@ -152,7 +152,7 @@ end
OpenCL.nextafter,
OpenCL.powr,
]
- @warn "OpenCL-specific binary - $T, $f"
+ @warn "OpenCL-specific binary - $T, $f"
x = rand(T)
y = rand(T)
@@ -167,7 +167,7 @@ end
x = rand(T)
y = rand(T)
z = rand(T)
- @warn "OpenCL-specific ternary - $T"
+ @warn "OpenCL-specific ternary - $T"
@test call_on_device(OpenCL.mad, x, y, z) ≈ x * y + z
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to open this on my fork.
I think there may be a mix of some runs taking longer than 60 minutes and some real hangs.