Add atomic float support

[michel2323]

JuliaGPU/oneAPI.jl#544 Adding the SPV_EXT_shader_atomic_float_add extension in oneAPI.jl seems to work.

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/lib/intrinsics/src/atomic.jl b/lib/intrinsics/src/atomic.jl
index a93f926..d627741 100644
--- a/lib/intrinsics/src/atomic.jl
+++ b/lib/intrinsics/src/atomic.jl
@@ -47,17 +47,21 @@ for gentype in atomic_types, as in atomic_memory_types
 @device_function atomic_xor!(p::LLVMPtr{$gentype,$as}, val::$gentype) =
     @builtin_ccall("atomic_xor", $gentype,
                    (LLVMPtr{$gentype,$as}, $gentype), p, val)
-end
-if gentype in atomic_integer_types
-    @eval begin
-    @device_function atomic_xchg!(p::LLVMPtr{$gentype,$as}, val::$gentype) =
-        @builtin_ccall("atomic_xchg", $gentype,
-                    (LLVMPtr{$gentype,$as}, $gentype), p, val)
-
-    @device_function atomic_cmpxchg!(p::LLVMPtr{$gentype,$as}, cmp::$gentype, val::$gentype) =
-        @builtin_ccall("atomic_cmpxchg", $gentype,
-                    (LLVMPtr{$gentype,$as}, $gentype, $gentype), p, cmp, val)
     end
+    if gentype in atomic_integer_types
+        @eval begin
+            @device_function atomic_xchg!(p::LLVMPtr{$gentype, $as}, val::$gentype) =
+                @builtin_ccall(
+                "atomic_xchg", $gentype,
+                (LLVMPtr{$gentype, $as}, $gentype), p, val
+            )
+
+            @device_function atomic_cmpxchg!(p::LLVMPtr{$gentype, $as}, cmp::$gentype, val::$gentype) =
+                @builtin_ccall(
+                "atomic_cmpxchg", $gentype,
+                (LLVMPtr{$gentype, $as}, $gentype, $gentype), p, cmp, val
+            )
+        end
 end
 end
 

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.19%. Comparing base (95039b8) to head (1ac8383).

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #399       +/-   ##
===========================================
+ Coverage   31.39%   80.19%   +48.79%     
===========================================
  Files          11       12        +1     
  Lines         672      722       +50     
===========================================
+ Hits          211      579      +368     
+ Misses        461      143      -318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[michel2323]

Bump. Can someone take a look? @vchuravy ? I don't see how the failing tests are connected to the changes here.

[maleadt]

Thanks. Can you add a test that works here too?
CI failures look unrelated.