Skip to content

Use stacked method tables #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use stacked method tables #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c833a8
Use stacked method tables
vchuravy Jun 17, 2025
357c4d3
fixup! Use stacked method tables
vchuravy Jun 17, 2025
1547745
cleanup
vchuravy Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ Adapt = "4"
CEnum = "0.4, 0.5"
ExprTools = "0.1"
GPUArrays = "11.2.1"
GPUCompiler = "1.5"
GPUCompiler = "1.6"
GPUToolbox = "0.1, 0.2"
KernelAbstractions = "0.9.1"
LLVM = "6, 7, 8, 9"
NEO_jll = "=24.26.30049"
Preferences = "1"
SPIRVIntrinsics = "0.2"
SPIRVIntrinsics = "0.4"
SPIRV_LLVM_Translator_jll = "20"
SpecialFunctions = "1.3, 2"
StaticArrays = "1"
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/compilation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const oneAPICompilerJob = CompilerJob{SPIRVCompilerTarget,oneAPICompilerParams}

GPUCompiler.runtime_module(::oneAPICompilerJob) = oneAPI

GPUCompiler.method_table(::oneAPICompilerJob) = method_table
GPUCompiler.method_table_view(job::oneAPICompilerJob) = GPUCompiler.StackedMethodTable(job.world, method_table, SPIRVIntrinsics.method_table)

# filter out OpenCL built-ins
# TODO: eagerly lower these using the translator API
Expand Down
4 changes: 4 additions & 0 deletions src/oneAPI.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,14 @@ include("../lib/level-zero/oneL0.jl")
using .oneL0
functional() = oneL0.functional[]


# device functionality
import SPIRVIntrinsics
SPIRVIntrinsics.@import_all
SPIRVIntrinsics.@reexport_public
# local method table for device functions
Base.Experimental.@MethodTable(method_table)

include("device/runtime.jl")
include("device/array.jl")
include("device/quirks.jl")
Expand Down
2 changes: 1 addition & 1 deletion src/oneAPIKernels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module oneAPIKernels

using ..oneAPI
using ..oneAPI: @device_override
using ..oneAPI: @device_override, method_table

import KernelAbstractions as KA

Expand Down