Skip to content

Conversation

michel2323
Copy link
Member

@amontoison Sorry, I also worked on it yesterday 🙂. This support Complex and throws errors for the trsm etc.

Copy link
Contributor

github-actions bot commented Sep 17, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@michel2323
Copy link
Member Author

For the complex cases, I can also post a warning that performance is degraded due to additional allocation. I think it might still be valuable in some cases.

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 80.80000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.74%. Comparing base (3d3278d) to head (9040ac3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/mkl/wrappers_sparse.jl 85.47% 17 Missing ⚠️
lib/mkl/interfaces.jl 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   79.70%   79.74%   +0.04%     
==========================================
  Files          45       45              
  Lines        2818     2943     +125     
==========================================
+ Hits         2246     2347     +101     
- Misses        572      596      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison
Copy link
Member

@michel2323 Is it fine for you to merge my PR before and then rebase your PR on top of it?
It will be easier to review for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants