Skip to content

Fix Julia 1.12 issues #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Julia 1.12 issues #529

wants to merge 4 commits into from
+31 −9

Conversation

michel2323
Copy link
Member

No description provided.

@michel2323 michel2323 mentioned this pull request Sep 17, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025 •
edited
Loading

Your PR no longer requires formatting changes. Thank you for your contribution!

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.70%. Comparing base (3d3278d) to head (27fca08).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   79.70%   79.70%           
=======================================
  Files          45       45           
  Lines        2818     2818           
=======================================
  Hits         2246     2246           
  Misses        572      572

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MagicMuscleMan
MagicMuscleMan suggested changes Sep 19, 2025
View reviewed changes
Copy link

@MagicMuscleMan MagicMuscleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one indent issue, this looks good to me.

I tested the change and it fixes the problem for me.

Thanks for creating and submitting the PR!

src/broadcast.jl
Comment on lines +15 to 17
Broadcast.BroadcastStyle(
::oneArrayStyle{N, B1},
::oneArrayStyle{N, B2}) where {N,B1,B2} =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both arguments should be indented identically or there should be no line break at all. I think 91 characters is still reasonable.

Suggested change
Broadcast.BroadcastStyle(
::oneArrayStyle{N, B1},
::oneArrayStyle{N, B2}) where {N,B1,B2} =
Broadcast.BroadcastStyle(::oneArrayStyle{N, B1}, ::oneArrayStyle{N, B2}) where {N,B1,B2} =

@michel2323
Copy link
Member Author

@maleadt Anything I can do here about? JuliaGPU/GPUCompiler.jl#101

<html>
<body>
<!--StartFragment-->
gpuarrays/math/intrinsics                     (3) \|     1.97 \|   0.00 \|  0.0 \|     153.90 \|  2049.44 \|
--
  | From worker 5:	InvalidBitWidth: Invalid bit width in input: 128
  | From worker 5:	InvalidBitWidth: Invalid bit width in input: 128
  | From worker 5:	InvalidBitWidth: Invalid bit width in input: 128
  | From worker 5:	InvalidBitWidth: Invalid bit width in input: 128
  | gpuarrays/statistics                          (5) \|         failed at 2025-09-19T14:03:47.020
  | TaskFailedException
  |  
  | nested task error: InterruptException:
  | Stacktrace:
  | [1] try_yieldto(undo::typeof(identity))
  | @ Base ./task.jl:1128
  | [2] throwto(t::Task, exc::Any)
  | @ Base ./task.jl:1145
  | [3] (::var"#58#59"{Dict{String, DateTime}, Task, var"#recycle_worker#recycle_worker##0"})()
  | @ Main /var/lib/buildkite-agent/builds/sagittarius-maleadt-net/julialang/oneapi-dot-jl/test/runtests.jl:263Testing finished in 4 minutes, 15 seconds, 68 milliseconds
  | Worker 5 failed running test gpuarrays/statistics:
  | Some tests did not pass: 48 passed, 0 failed, 4 errored, 0 broken.
  | gpuarrays/statistics: Error During Test at /root/.cache/julia-buildkite-plugin/depots/05c310bb-cd1d-4bbf-ad62-61f2372c55f0/packages/GPUArrays/ZRk7Q/test/testsuite/statistics.jl:54
  | Test threw exception
  | Expression: compare(cor, AT, rand(ET, s, 2), nans = true)
  | Failed to translate LLVM code to SPIR-V.
  | If you think this is a bug, please file an issue and attach /tmp/jl_lu9Ozc7qvM.bc.
  | Stacktrace:
  | [1] error(s::String)
  | @ Base ./error.jl:44
  | [2] mcgen(job::GPUCompiler.CompilerJob{GPUCompiler.SPIRVCompilerTarget, oneAPI.oneAPICompilerParams}, mod::LLVM.Module, format::LLVM.API.LLVMCodeGenFileType)
  | @ GPUCompiler ~/.cache/julia-buildkite-plugin/depots/05c310bb-cd1d-4bbf-ad62-61f2372c55f0/packages/GPUCompiler/Ecaql/src/spirv.jl:154
  | [3] macro expansion
  | @ ~/.cache/julia-buildkite-plugin/depots/05c310bb-cd1d-4bbf-ad62-61f2372c55f0/packages/Tracy/tYwAE/src/tracepoint.jl:163 [inlined]

<!--EndFragment-->
</body>
</html>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MagicMuscleMan MagicMuscleMan MagicMuscleMan requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michel2323 @MagicMuscleMan