Skip to content

only call sizeof on isbits types #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

only call sizeof on isbits types #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ba9a5
only call sizeof on isbits
rafaqz Aug 31, 2025
edc8e66
test broadcast over strings
rafaqz Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,20 @@ function common_chunks(s, args...)
all(ar -> isa(eachchunk(ar), GridChunks), chunkedarrays) ||
error("Currently only chunks of type GridChunks can be merged by broadcast")
if isempty(chunkedarrays)
totalsize = sum(sizeof ∘ eltype, args)
return estimate_chunksize(s, totalsize)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function does actually the wrong thing. Can we just call into this method

DiskArrays.jl/src/chunks.jl

Line 441 in 877fd67

estimate_chunksize(a::AbstractArray) = estimate_chunksize(size(a), element_size(a))
and have the non-isbits types covered?

# Estimate chunk size for isbits
if all(map(isbits ∘ eltype, args))
totalsize = sum(sizeof ∘ eltype, args)
return estimate_chunksize(s, totalsize)
else # Otherwise just use one huge chunk, we dont know what the object is
return GridChunks(s, s)
end
elseif length(chunkedarrays) == 1
return eachchunk(only(chunkedarrays))
else
allchunks = collect(map(eachchunk, chunkedarrays))
tt = ntuple(N) do n
csnow = filter(allchunks) do cs
ndims(cs) >= n && first(first(cs.chunks[n])) < last(last(cs.chunks[n]))
ndims(cs) >= n && first(first(cs.chunks[n])) < last(last(cs.chunks[n]))
end
isempty(csnow) && return RegularChunks(1, 0, s[n])

Expand Down
5 changes: 5 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,3 +1116,8 @@ end
@inferred DiskArrays.DiskIndex(a_view5, (1:1, 1:1, 1:1, 1:1, 1:1), DiskArrays.NoBatch()) #DiskArrays.DiskIndex
@inferred DiskArrays.DiskIndex(a_view6, (1:1, 1:1, 1:1, 1:1, 1:1, 1:1), DiskArrays.NoBatch()) #DiskArrays.DiskIndex
end

@testset "test broadcast over strings" begin
a = UnchunkedDiskArray(["a", "b", "c"])
@test all(a .== ["a", "b", "c"])
end
Loading