Skip to content

Add warning to imfilter! for transposed OffsetVectors #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add warning to imfilter! for transposed OffsetVectors #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
060b437
Add warning to imfilter! for transposed OffsetVectors
BioTurboNick Dec 8, 2023
0d011c0
Factor out warning
BioTurboNick Dec 8, 2023
b36b43e
Fix type (ProcessedKernel not yet available)
BioTurboNick Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/imfilter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ end

# Step 5: if necessary, pick an algorithm
function imfilter!(out::AbstractArray, img::AbstractArray, kernel::ProcessedKernel, border::AbstractBorder)
_warn_if_transposed_from_offset_vector(kernel)
imfilter!(out, img, kernel, border, filter_algorithm(out, img, kernel))
end

Expand Down
11 changes: 11 additions & 0 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,14 @@ accumfilter(pixelval::Colorant{N0f8}, filterval::N0f8) = float32(c)*Float32(filt
# In theory, the following might need to be specialized. For safety, make it a
# standalone function call.
safe_for_prod(x, ref) = oftype(ref, x)

function _warn_if_transposed_from_offset_vector(kernel::Tuple)
if any(_is_transposed_offset_vector, kernel)
@warn "A transposed OffsetVector automatically has an index of 1 in the first dimension. " *
"Consider using an OffsetMatrix to control the offset of each dimension."
end
end

_is_transposed_offset_vector(x::Adjoint{<:Any, <:OffsetVector}) = Base.has_offset_axes(parent(x))
_is_transposed_offset_vector(x::Transpose{<:Any, <:OffsetVector}) = Base.has_offset_axes(parent(x))
_is_transposed_offset_vector(_) = false