-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Lazy JLLs #50687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Lazy JLLs #50687
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
# This file serves as a way to provide access to libraries that Base needs | ||
# that are usually included as artifacts. We can't use Artifacts this early | ||
# becuase we haven't bootstrapped far enough, so this file contains "Base" | ||
staticfloat marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# JLLs that are manually adapted to load things from hardcoded paths so that | ||
# we can bootstrap, but once GMP_jll, MPFR_jll, etc... are loaded, we replace | ||
# the definitions here with the `LazyLibrary` objects defined there, as they | ||
# may be overloaded by Preferences and refer to a different library than we | ||
# would have used during bootstrap. | ||
module JLLAdapters | ||
|
||
# We're early enough that we don't have access to `Sys.iswindows()`, etc... | ||
const UNAME = ccall(:jl_get_UNAME, Any, ())::Symbol | ||
const early_pathsep = (UNAME === :Windows || UNAME === :NT) ? "\\" : "/" | ||
|
||
function early_joinpath(pieces...) | ||
result = pieces[1] | ||
for piece in pieces[2:end] | ||
result = string(result, early_pathsep, piece) | ||
end | ||
return result | ||
end | ||
|
||
""" | ||
LazyLibraryPath | ||
Helper type for lazily constructed library paths for use with `LazyLibrary`. | ||
Arguments are passed to `joinpath()`. Arguments must be able to have | ||
`string()` called on them. | ||
``` | ||
libfoo = LazyLibrary(LazyLibraryPath(prefix, "lib/libfoo.so.1.2.3")) | ||
``` | ||
""" | ||
struct LazyLibraryPath | ||
pieces::Vector | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This probably means this code will not support trimming. |
||
LazyLibraryPath(pieces::Vector) = new(pieces) | ||
end | ||
LazyLibraryPath(args...) = LazyLibraryPath(collect(args)) | ||
Base.string(llp::LazyLibraryPath) = early_joinpath([string(p) for p in llp.pieces]...) | ||
Base.cconvert(::Type{Cstring}, llp::LazyLibraryPath) = Base.cconvert(Cstring, string(llp)) | ||
# Define `print` so that we can wrap this in a `LazyString` | ||
Base.print(io::IO, llp::LazyLibraryPath) = print(io, string(llp)) | ||
|
||
# Helper to get `Sys.BINDIR` at runtime | ||
struct SysBindirGetter; end | ||
staticfloat marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Base.string(::SysBindirGetter) = string(ccall(:jl_get_julia_bindir, Any, ())::String, early_pathsep, "..") | ||
|
||
""" | ||
BundledLazyLibraryPath | ||
Helper type for lazily constructed library paths that are stored within the | ||
bundled Julia distribution, primarily for use by Base modules. | ||
``` | ||
libfoo = LazyLibrary(BundledLazyLibraryPath("lib/libfoo.so.1.2.3")) | ||
``` | ||
""" | ||
BundledLazyLibraryPath(subpath) = LazyLibraryPath(SysBindirGetter(), subpath) | ||
|
||
# PCRE | ||
if (UNAME === :Windows || UNAME === :NT) | ||
const libpcre2_8_name = "bin/libpcre2-8-0.dll" | ||
elseif (UNAME === :Apple || UNAME === :Darwin) | ||
const libpcre2_8_name = "lib/libpcre2-8.0.dylib" | ||
else | ||
const libpcre2_8_name = "lib/libpcre2-8.so.0" | ||
end | ||
|
||
const libpcre2_8 = Ref{Any}(BundledLazyLibraryPath(libpcre2_8_name)) | ||
function get_libpcre2_8() | ||
if isa(libpcre2_8[], LazyLibraryPath) | ||
return string(libpcre2_8[]) | ||
end | ||
return libpcre2_8[] | ||
end | ||
|
||
# GMP | ||
if (UNAME === :Windows || UNAME === :NT) | ||
const libgmp_name = "bin/libgmp-10.dll" | ||
elseif (UNAME === :Apple || UNAME === :Darwin) | ||
const libgmp_name = "lib/libgmp.10.dylib" | ||
else | ||
const libgmp_name = "lib/libgmp.so.10" | ||
end | ||
const libgmp = Ref{Any}(BundledLazyLibraryPath(libgmp_name)) | ||
function get_libgmp() | ||
if isa(libgmp[], LazyLibraryPath) | ||
return string(libgmp[]) | ||
end | ||
return libgmp[] | ||
end | ||
|
||
|
||
# MPFR | ||
if (UNAME === :Windows || UNAME === :NT) | ||
const libmpfr_name = "bin/libmpfr-6.dll" | ||
elseif (UNAME === :Apple || UNAME === :Darwin) | ||
const libmpfr_name = "lib/libmpfr.6.dylib" | ||
else | ||
const libmpfr_name = "lib/libmpfr.so.6" | ||
end | ||
const libmpfr = Ref{Any}(BundledLazyLibraryPath(libmpfr_name)) | ||
function get_libmpfr() | ||
# Work around early bootstrap problems where we need to load `libgmp` | ||
# when `libmpfr` is loaded. This only works if we're far enough along | ||
# in bootstrap to be able to call `dlopen()`! Later, `libmpfr[]` | ||
# is going to return a `LazyLibrary` that will have a dependency on | ||
# `libgmp[]`. | ||
if isa(libmpfr[], LazyLibraryPath) | ||
Base.Libc.Libdl.dlopen(get_libgmp()) | ||
return string(libmpfr[]) | ||
end | ||
return libmpfr[] | ||
end | ||
|
||
|
||
end # module JLLAdapters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Insert LazyLibrary for `libpcre`, although at this time this gets lazily | ||
staticfloat marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# on startup because `include()` calls `isdirpath()` which has a regex in it. | ||
using Base.JLLAdapters: libpcre2_8, libpcre2_8_name | ||
using Base.Libc.Libdl: BundledLazyLibraryPath, LazyLibrary | ||
libpcre2_8[] = LazyLibrary(BundledLazyLibraryPath(libpcre2_8_name)) | ||
|
||
|
||
# Insert LazyLibrary for `libgmp` | ||
using Base.JLLAdapters: libgmp, libgmp_name | ||
using Base.Libc.Libdl: BundledLazyLibraryPath, LazyLibrary | ||
using Base.GMP: libgmp_init | ||
libgmp[] = LazyLibrary(BundledLazyLibraryPath(libgmp_name); on_load_callback=libgmp_init) | ||
|
||
# Insert LazyLibrary for `libmpfr` | ||
using Base.JLLAdapters: libgmp, libmpfr, libmpfr_name | ||
using Base.Libc.Libdl: BundledLazyLibraryPath, LazyLibrary | ||
using Base.MPFR: libmpfr_init | ||
libmpfr[] = LazyLibrary(BundledLazyLibraryPath(libmpfr_name); dependencies=[libgmp[]], on_load_callback=libmpfr_init) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.