Skip to content

fix hashing of complex values with zero imaginary part #59779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix hashing of complex values with zero imaginary part #59779

wants to merge 1 commit into from

Conversation

adienes
Copy link
Member

@adienes adienes commented Oct 8, 2025

follow up to a minor typo introduced in #59185 which caused hash(0im) != hash(0), and adds some tests for this case

@adienes adienes added bugfix This change fixes an existing bug hashing labels Oct 8, 2025
@adienes adienes added this to the 1.13 milestone Oct 8, 2025
vtjnash
vtjnash approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks

@nsajko nsajko added the complex Complex numbers label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug complex Complex numbers hashing

Projects

None yet

Milestone

1.13

Development

Successfully merging this pull request may close these issues.

3 participants

@adienes @vtjnash @nsajko