Make = and const toplevel-preserving syntax
#59784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xal-0
added
compiler:lowering
xal-0
force-pushed
the
toplevel-global-lowering
branch
from
e890d9a to
52ed9a2
Compare
vtjnash
approved these changes
Oct 8, 2025
Previously, `map-cl-convert` would keep the toplevel flag only when the containing expression was toplevel and each element of the list passed to it satisfied `toplevel-preserving?`. Instead, make it so `toplevel-preserving?` expressions are those where the toplevel flag should be propagated to the children during closure conversion. Fixes JuliaLang#59755.
xal-0
force-pushed
the
toplevel-global-lowering
branch
from
52ed9a2 to
9174682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
map-cl-convertwould keep the toplevel flag only when the containing expression was toplevel and each element of the list passed to it satisfiedtoplevel-preserving?. Instead, make it sotoplevel-preserving?expressions are those where the toplevel flag should be propagated to the children during closure conversion.Fixes #59755.