Skip to content

enable ENABLE_VIRTUAL_TERMINAL_INPUT on Windows to enable bracketed paste when supported #59791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

enable ENABLE_VIRTUAL_TERMINAL_INPUT on Windows to enable bracketed paste when supported #59791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions stdlib/REPL/src/LineEdit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,10 @@ function refresh_multi_line(termbuf::TerminalBuffer, terminal::UnixTerminal, buf
if writer isa Base.TTY && !Base.ispty(writer)::Bool
_reset_console_mode(writer.handle)
end
reader = Terminals.pipe_reader(terminal)
if reader isa Base.TTY && !Base.ispty(reader)::Bool
_enable_virtual_terminal_input(reader.handle)
end
end
# Write out the prompt string
lindent = write_prompt(termbuf, prompt, hascolor(terminal))::Int
Expand Down Expand Up @@ -1689,12 +1693,16 @@ end
if Sys.iswindows()

#= Get/SetConsoleMode flags =#
# Output flags
const ENABLE_PROCESSED_OUTPUT = UInt32(0x0001)
const ENABLE_WRAP_AT_EOL_OUTPUT = UInt32(0x0002)
const ENABLE_VIRTUAL_TERMINAL_PROCESSING = UInt32(0x0004)
const DISABLE_NEWLINE_AUTO_RETURN = UInt32(0x0008)
const ENABLE_LVB_GRID_WORLDWIDE = UInt32(0x0010)

# Input flags
const ENABLE_VIRTUAL_TERMINAL_INPUT = UInt32(0x0200)

#= libuv flags =#
const UV_TTY_SUPPORTED = 0
const UV_TTY_UNSUPPORTED = 1
Expand All @@ -1716,6 +1724,24 @@ function _reset_console_mode(handle::Ptr{Cvoid})
return nothing
end

function _enable_virtual_terminal_input(handle::Ptr{Cvoid})
# Enable virtual terminal input mode for bracketed paste support on Windows Terminal
# See https://github.com/JuliaLang/julia/issues/53763
# Query libuv to see whether it expects the console to support virtual terminal sequences
vterm_state = Ref{Cint}()
ccall(:uv_tty_get_vterm_state, Cint, (Ref{Cint},), vterm_state)

if vterm_state[] == UV_TTY_SUPPORTED
mode = Ref{UInt32}()
if ccall(:GetConsoleMode, stdcall, Int32, (Ptr{Cvoid}, Ref{UInt32}), handle, mode) != 0
mode[] |= ENABLE_VIRTUAL_TERMINAL_INPUT
ccall(:SetConsoleMode, stdcall, Int32, (Ptr{Cvoid}, UInt32), handle, mode[])
end
end

return nothing
end

end

# returns the width of the written prompt
Expand Down Expand Up @@ -2938,6 +2964,13 @@ function prompt!(term::TextTerminal, prompt::ModalInterface, s::MIState = init_s
status ∈ (:ok, :ignore) || break
end
raw!(term, true)
@static if Sys.iswindows()
# Enable virtual terminal input mode for bracketed paste support on Windows Terminal
reader = Terminals.pipe_reader(term)
if reader isa Base.TTY
_enable_virtual_terminal_input(reader.handle)
end
end
enable_bracketed_paste(term)
try
activate(prompt, s, term, term)
Expand Down