-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Try a blocking write before doing async write call #59795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
On a simple http benchmark this is a 7x throughput improvement.
Motivating thing was https://github.com/AbhimanyuAryan/c_http_jl/ the remaining differences are, we always do async reads which might not be optimal, but libuv doesn't have a try_read (even thought it might eventually). The other is node seems to go into the |
This comment was marked as off-topic.
This comment was marked as off-topic.
Can we actually see the benchmark? |
const ROUTER = HTTP.Router()
HTTP.register!(ROUTER, "GET", "/", req->HTTP.Response(200, "Hi"))
# You can register more
HTTP.register!(ROUTER, "GET", "/bye", req->HTTP.Response(200, "Bye!"))
HTTP.serve(ROUTER) and using https://www.npmjs.com/package/autocannon |
Build doesn't seem happy |
On a simple http benchmark this is a 7x throughput improvement.