Skip to content

Conversation

giordano
Copy link
Member

#59374 made time_start a const but now there's no way to instantiate a DefaultTestSet with a custom time_start without passing also all other fields.

@giordano giordano requested a review from vchuravy October 11, 2025 08:23
@giordano giordano added the testsystem The unit testing framework and Test stdlib label Oct 11, 2025
@giordano
Copy link
Member Author

giordano commented Oct 11, 2025

I initially thought this would have been necessary for JuliaTesting/ParallelTestRunner.jl#21, but I figured out how to rearrange the code in the package not to need this. Still, I think this may be useful regardless of that issue, it's still impossible to pass a custom time_start in case someone needs to construct test set object after it has started.

giordano referenced this pull request in JuliaTesting/ParallelTestRunner.jl Oct 11, 2025
@giordano giordano merged commit d3f2952 into JuliaLang:master Oct 12, 2025
9 checks passed
@giordano giordano deleted the mg/defaulttestset-time-start branch October 12, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testsystem The unit testing framework and Test stdlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant