set the auto_refresh_time_delay to 0 on Windows as well
#59827
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
system:windows
|
Can you add a note to your v1.13 release checklist to delete this dead code after we cut the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts #39538 since it no longer seems beneficial. With
auto_refresh_time_delay=0.0on Windows, pasting a 1500 line long function took 29 seconds, while withauto_refresh_time_delay=0.05(which is the current value) it took 36 seconds.#59825 should also effectively make this obsolete.
It also causes other issues like #59788.
Fixes #59788