-
Notifications
You must be signed in to change notification settings - Fork 0
Update for Manifolds.jl 0.11 and Runic.jl formatting #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just maybe check with the other documentations and their projects how this “please load the package from the parent folder” can be simplified a bit.
Oh and if you want to also switch to the pure-Julia notebook runner you do not need a Jupyter Julia version but just have to specify an engine (namely Julia) in the _quarto.yml |
Thanks, something like that? |
at least at first glance make.jl and the new quarto setup look correct :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 64.94% 64.80% -0.14%
==========================================
Files 8 8
Lines 425 429 +4
==========================================
+ Hits 276 278 +2
- Misses 149 151 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hm, there is still something wrong with docs here. Could you check it @kellertuer ? I will check ManifoldDiffEq.jl. |
The example in docs is doing something completely not right 😕 |
Sadly, something doesn't seem to be AD-able in the new code and I've switched do finite differences for now.