Skip to content

feat: implement Base.trylock, subtype Base.AbstractLock for ReadWriteLock #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: implement Base.trylock, subtype Base.AbstractLock for ReadWriteLock #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d49ace
refactor: make `ReadWriteLock` subtype `Base.AbstractLock`
AayushSabharwal Aug 6, 2025
44aa8de
feat: implement `Base.trylock` for `ReadWriteLock`
AayushSabharwal Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/rwlock.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ while the write side is acquired/released via `lock(rw)` and `unlock(rw)`.
While a writer is active, all readers will block. Once the writer is finished,
all pending readers will be allowed to acquire/release before the next writer.
"""
mutable struct ReadWriteLock
mutable struct ReadWriteLock <: Base.AbstractLock
writelock::ReentrantLock
readwait::Threads.Condition
writeready::Threads.Event
Expand Down Expand Up @@ -95,6 +95,23 @@ function Base.lock(rw::ReadWriteLock)
return
end

function Base.trylock(rw::ReadWriteLock)
Copy link

@oscardssmith oscardssmith Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this trying to readlock or write lock?

Copy link
Author

@AayushSabharwal AayushSabharwal Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writelock, since lock and unlock are for writelock. The readlock equivalent would likely be a custom tryreadlock function.

success = trylock(rw.writelock)
success || return false

r = (@atomic :acquire_release rw.readercount -= MaxReaders) + MaxReaders
if r != 0
r = (@atomic :acquire_release rw.readercount += MaxReaders)
if r > 0
# wake up waiting readers
Base.@lock rw.readwait notify(rw.readwait)
end
unlock(rw.writelock)
return false
end
return true
end

Base.islocked(rw::ReadWriteLock) = islocked(rw.writelock)

function Base.unlock(rw::ReadWriteLock)
Expand All @@ -107,4 +124,4 @@ function Base.unlock(rw::ReadWriteLock)
return
end

end
end