Skip to content

test: update codegen tests #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025
Merged

test: update codegen tests #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da3bd6d
test: update codegen tests
AayushSabharwal Jan 13, 2025
194aa85
refactor: don't use `NaNMath.pow` in codegen rewriters if integral ex…
AayushSabharwal Jan 13, 2025
f5611aa
fix: fix stack overflow in `function_to_expr`
AayushSabharwal Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/code.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,18 +140,18 @@ end

function function_to_expr(op::typeof(^), O, st)
args = arguments(O)
if length(args) == 2 && args[2] isa Real && args[2] < 0
ex = args[1]
if args[2] == -1
return toexpr(Term(inv, Any[ex]), st)
else
args = Any[Term(inv, Any[ex]), -args[2]]
op = get(st.rewrites, :nanmath, false) ? op : NaNMath.pow
return toexpr(Term(op, args), st)
end
if args[2] isa Real && args[2] < 0
args[1] = Term(inv, Any[args[1]])
args[2] = -args[2]
end
if isequal(args[2], 1)
return toexpr(args[1], st)
end
if get(st.rewrites, :nanmath, false) === true && !(args[2] isa Integer)
op = NaNMath.pow
return toexpr(Term(op, args), st)
end
get(st.rewrites, :nanmath, false) === true || return nothing
return toexpr(Term(NaNMath.pow, args), st)
return nothing
end

function function_to_expr(::typeof(SymbolicUtils.ifelse), O, st)
Expand Down
16 changes: 8 additions & 8 deletions test/code.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,19 @@ nanmath_st.rewrites[:nanmath] = true
@test toexpr(NaNMath.pow(a, b), nanmath_st) == :($(NaNMath.pow)(a, b))

@test toexpr(a^2) == :($(^)(a, 2))
@test toexpr(a^2, nanmath_st) == :($(NaNMath.pow)(a, 2))
@test toexpr(NaNMath.pow(a, 2)) == :($(NaNMath.pow)(a, 2))
@test toexpr(NaNMath.pow(a, 2), nanmath_st) == :($(NaNMath.pow)(a, 2))
@test toexpr(a^2, nanmath_st) == :($(^)(a, 2))
@test toexpr(NaNMath.pow(a, 2)) == :($(^)(a, 2))
@test toexpr(NaNMath.pow(a, 2), nanmath_st) == :($(^)(a, 2))

@test toexpr(a^-1) == :($(/)(1, a))
@test toexpr(a^-1, nanmath_st) == :($(/)(1, a))
@test toexpr(NaNMath.pow(a, -1)) == :($(NaNMath.pow)(a, -1))
@test toexpr(NaNMath.pow(a, -1), nanmath_st) == :($(NaNMath.pow)(a, -1))
@test toexpr(NaNMath.pow(a, -1)) == :($(inv)(a))
@test toexpr(NaNMath.pow(a, -1), nanmath_st) == :($(inv)(a))

@test toexpr(a^-2) == :($(/)(1, $(^)(a, 2)))
@test toexpr(a^-2, nanmath_st) == :($(/)(1, $(NaNMath.pow)(a, 2)))
@test toexpr(NaNMath.pow(a, -2)) == :($(NaNMath.pow)(a, -2))
@test toexpr(NaNMath.pow(a, -2), nanmath_st) == :($(NaNMath.pow)(a, -2))
@test toexpr(a^-2, nanmath_st) == :($(/)(1, $(^)(a, 2)))
@test toexpr(NaNMath.pow(a, -2)) == :($(^)($(inv)(a), 2))
@test toexpr(NaNMath.pow(a, -2), nanmath_st) == :($(^)($(inv)(a), 2))

f = GlobalRef(NaNMath, :sin)
test_repr(toexpr(LiteralExpr(:(let x=1, y=2
Expand Down
Loading