Skip to content

fix compare tests #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025
Merged

fix compare tests #229

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6144a
fix compare tests
tanmaykm Jun 21, 2025
ae7cf44
Fix typo (Apply suggestions from code review)
DilumAluthge Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions test/read_only_api_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,21 @@ end
@test hasghobj("master", first(branches(ghjl; auth = auth)))

# test GitHub.compare
@test compare(ghjl, "master", "master~"; auth = auth).behind_by == 1
let comparison = compare(ghjl, "master~", "master"; auth = auth)
@test comparison.ahead_by == 1
@test length(comparison.commits) == 1
# check if the latest commit it a merge commit
latest_commit = GitHub.branch(ghjl, "master"; auth=auth).commit
is_latest_commit_merge = length(latest_commit.parents) > 1
if is_latest_commit_merge
@test compare(ghjl, "master", "master~"; auth = auth).behind_by >= 1
let comparison = compare(ghjl, "master~", "master"; auth = auth)
@test comparison.ahead_by >= 1
@test length(comparison.commits) >= 1
end
else
@test compare(ghjl, "master", "master~"; auth = auth).behind_by == 1
let comparison = compare(ghjl, "master~", "master"; auth = auth)
@test comparison.ahead_by == 1
@test length(comparison.commits) == 1
end
end

# test GitHub.file, GitHub.directory, GitHub.readme, GitHub.permalink
Expand Down
Loading