Reference new gumbo-parser upstream #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@txgk, thank you for continuing to work on Gumbo. For this change to take place, we need to update the Yggdrasil side of things. Done, here: JuliaPackaging/Yggdrasil#12015 After the PR goes through, we need to bring Gumbo_jll up to date (I'll do it): https://github.com/JuliaBinaryWrappers/Gumbo_jll.jl Only then can we "say" Gumbo.jl is using the new upstream. |
|
Hello, @algunion This is so nice to see someone reply to my request, thank you for working on it! :) I'm ready to cooperate on it with you and already left a little note regarding build recipe implementation here: JuliaPackaging/Yggdrasil#12015 (comment) Best regards, Grigory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Gumbo.jl developers. Thank you for maintaining these nice bindings!
Since the original gumbo-parser repository was archived, significant progress has been made in the new, actively maintained repository. The version from the original repo has fallen far behind in terms of HTML specification compliance and contains several critical bugs.
Over the past year, gumbo-parser has seen substantial improvements. It now passes all html5lib-tests, has better unit tests coverage, uses modern build system and has fuzzy testing facilities. You can find the updated repository here: https://codeberg.org/gumbo-parser/gumbo-parser
Many major distributions have already adopted the updated version, including Alpine, Arch, Debian, Fedora, FreeBSD, Gentoo, Homebrew, NixOS, OpenBSD, Slackware, Ubuntu, and others.
I'm the new maintainer of Gumbo, by the way. My main incentive for taking on this job is the use of Gumbo in my other projects, one public one of which is the Newsraft.
So I just would like to try to alleviate your doubts about the reliability of Gumbo as a dependency. I plan to support it for as long as possible with the respect to all the initial ideas laid out by the original author of Gumbo. If you ever encounter any problems with the library, feel free to reach out at https://codeberg.org/gumbo-parser/gumbo-parser/issues
Best regards, Grigory