Skip to content

Conversation

@ms-shankar
Copy link
Contributor

Description

Closes issue #82

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the kaos contribution guidelines
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ms-shankar ms-shankar self-assigned this Nov 26, 2019
@ms-shankar ms-shankar changed the title [WIP]K-82: General refactor and Cli unit tests K-82: General refactor and CLI unit tests Jan 24, 2020
@ms-shankar ms-shankar marked this pull request as ready for review January 24, 2020 09:41
Copy link
Contributor

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need refactoring, there is a lot of state management and conditional logic that will make a test pass or fail based on the state mutations within the test cases.

Copy link
Contributor

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side-effects and managed state at the level of the test case are still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants