Feature flag out the external dependencies #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would consider that a breaking change, which is fine for a new version |
Bumped the version accordingly and added documentation for the feature flags. |
Keats
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this change is that there are cases where people would like to use the general validation infrastructure, as well as the validation derive macros for simple data types, but do not want to pull in these extra dependencies to their dependency graph. The remaining validators that are not affected by this PR affect built-in types and as such are always enabled.
By enabling the new feature flags by default, this is not a breaking change, unless the downstream user explicitly set default-features = false.