Use performance.now instead of Date.now #2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e35f09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markijbema
approved these changes
Sep 23, 2025
chrarnoldus
commented
Sep 23, 2025
| const now = Date.now() | ||
| const now = performance.now() // kilocode_change | ||
| const timeSinceLastRequest = now - Task.lastGlobalApiRequestTime | ||
| const rateLimit = apiConfiguration?.rateLimitSeconds || 0 |
There was a problem hiding this comment.
We can try to fix it more aggressively by not waiting if rateLimit is zero anyway.
There was a problem hiding this comment.
That does make sense, i mean than we kan skip this altogether right?
There was a problem hiding this comment.
yeah, in fact if rateLimitDelay>rateLimit I think we're in trouble.
maybe Task.lastGlobalApiRequestTime being a global also causes problem.
We absolutely do. |
markijbema
approved these changes
Sep 23, 2025
src/core/task/__tests__/Task.spec.ts
Outdated
| const mockTime = Date.now() + (mockApiConfig.rateLimitSeconds + 1) * 1000 | ||
| Date.now = vi.fn(() => mockTime) | ||
| // kilocode_change start: use performance instead of Date | ||
| const originalDateNow = performance.now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by email