Skip to content

Conversation

jacebrowning
Copy link
Contributor

@jacebrowning jacebrowning commented Sep 24, 2025

PR purpose has changed. Original purpose lives with #8386 which should be merged first to unblock main

Og description:

The color change is likely a result of https://github.com/KittyCAD/engine/pull/3804.

See the fix results here: https://test-analysis-bot.hawk-dinosaur.ts.net/projects/KittyCAD/modeling-app/tests/380?branch=update-expected-colors

@jacebrowning jacebrowning self-assigned this Sep 24, 2025
Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Oct 2, 2025 2:16pm

@jacebrowning jacebrowning marked this pull request as ready for review September 24, 2025 00:42
@jacebrowning jacebrowning requested review from a team as code owners September 24, 2025 00:42
Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Instrumentation Performance Report

Merging #8385 will not alter performance

Comparing update-expected-colors (e8ab595) with main (4571c50)

Summary

✅ 139 untouched

@jacebrowning jacebrowning marked this pull request as draft September 24, 2025 02:58
@pierremtb pierremtb changed the title Update expected stream colors Disable the playwright cam setup and fix the world Sep 24, 2025
@jacebrowning
Copy link
Contributor Author

@pierremtb is this still needed? Feel free to close if not.

@pierremtb
Copy link
Contributor

Yeah @jacebrowning I'd like to keep it open and nuke that old code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants