Skip to content

Conversation

@benjamaan476
Copy link
Contributor

Adds customisation to chamfers, can specify the angle of the cut now. Either by the angle or by specifying both lengths of the chamfer. This doesn't deal with the typescript side of the work

@benjamaan476 benjamaan476 requested review from a team as code owners October 1, 2025 11:37
@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Oct 21, 2025 6:58pm

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 1, 2025

CodSpeed Performance Report

Merging #8469 will improve performances by 17.08%

Comparing ben/chamfer_angle (d3e1673) with main (e4e4c7e)1

Summary

⚡ 1 improvement
✅ 138 untouched
⏩ 92 skipped2

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation mock_execute_mike_stress_test_program 356.3 ms 304.3 ms +17.08%

Footnotes

  1. No successful run was found on main (89a85f7) during the generation of this report, so e4e4c7e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 92 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete these PNGs. You didn't intentionally remove them on this branch, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that was caused by redoing the docs, I didn't delete anything manually

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have a fix for this incoming.

Copy link
Contributor

@jtran jtran Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjamaan476 benjamaan476 merged commit 954e9bc into main Oct 21, 2025
77 checks passed
@benjamaan476 benjamaan476 deleted the ben/chamfer_angle branch October 21, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants