-
Notifications
You must be signed in to change notification settings - Fork 88
Sketch 2.0: KCL sketch block execution using ezpz solve #8499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jtran
wants to merge
12
commits into
main
Choose a base branch
from
jtran/sketch-block-exec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Instrumentation Performance ReportMerging #8499 will improve performances by 11.42%Comparing Summary
Benchmarks breakdown
Footnotes |
5735f20
to
48f06a2
Compare
3a74821
to
a1ef8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic sketch block execution and fixed constraints, calling the ezpz solver for the first time.
Implementation
e1 == e2
, build aConstraint
and push that into a Vec.I considered converting units "back" based on the units of the initial values of
var
s. I don't think it makes sense because in general, sketch vars can be passed around like any other values and it may not be intuitive where a sketch var originated. In the future, I could imagine having a parameter or sketch block annotation that configures which units to solve in. But it seems rare to care about it.Future Work