Bump node and electron (incl. macOS Tahoe fix) #8512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pierremtb
commented
Oct 7, 2025
| @@ -1 +1 @@ | |||
| v22.17.0 | |||
| v22.20.0 | |||
There was a problem hiding this comment.
There's a case to be made for us to simply do v22 here, but that's likely for a separate PR. Or have dependabot bump that I guess?
jacebrowning
approved these changes
Oct 7, 2025
pierremtb
commented
Oct 8, 2025
Comment on lines
+122
to
+127
| if ( | ||
| typeof window !== 'undefined' && | ||
| window.electron && | ||
| environment && | ||
| environment.domain | ||
| ) { |
There was a problem hiding this comment.
Hopefully should fix the tests, guess something has changed on the electron or node side? cc @nadr0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://releases.electronjs.org/release/v38.2.0
Also bumping node minor while we're at it