idle_timeout: Replace printing_time with mcu_uptime, add mcu_startup_unixtime #7124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unixtime This replaces the old printing_time variable with a new, unconditional mcu_uptime variable. Additionally there is a new mcu_startup_unixtime variable which enables unix time tracking in macros and thus printer restart independent time tracking, which was impossible before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the exact changes from #6010, I just recompiled them into a new PR with a cleaner history and more proper commit messages according to the contributing guidelines. It's been almost 3 years since my original PR and I've used these changes in my personal config since (as previously stated), without any problems, so I consider this well tested.
If I remember correctly, the last time I checked the
idle_timeout.printing_timevariable saw very little use at all by end-users, which is why we decided to replace it (without deprecation warnings or anything). As some time has passed, this might not be the case anymore and should be reconsidered.If only taken a quick glance, but from what I can tell printer restart independent time tracking is still not possible, so I still consider this feature as meaningful and essential.
PR commit description:
This replaces the old printing_time variable with a new, unconditional mcu_uptime variable. Additionally there is a new mcu_startup_unixtime variable which enables unix time tracking in macros and thus printer restart independent time tracking, which was impossible before.