Skip to content

Conversation

@Prashansa-K
Copy link
Collaborator

@Prashansa-K Prashansa-K commented Nov 6, 2025

Summary

shorthand_fields don't have defaults defined in the schema.
Thus, while using deck gateway dump --skip-defaults, they still show up.
This fix handles shorthand_fields by checking their default values against
their new fields represented by replaced_with or translate_backwards in the schema.

Tested here in deck: Kong/deck#1810

Issues resolved

For Kong/deck#1808

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.05%. Comparing base (e412658) to head (2dc1c40).

Files with missing lines Patch % Lines
pkg/dump/skip_defaults.go 83.33% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   28.87%   29.05%   +0.18%     
==========================================
  Files         119      119              
  Lines       16138    16192      +54     
==========================================
+ Hits         4660     4705      +45     
- Misses      10859    10864       +5     
- Partials      619      623       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Prashansa-K Prashansa-K merged commit 3bea2c9 into main Nov 6, 2025
26 checks passed
@Prashansa-K Prashansa-K deleted the fix/shorthand-field-defaults-skip branch November 6, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants