feat(entities-config-editor): migrate from PoC #2078
Draft
+2,497
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT1228
reviewed
Apr 14, 2025
packages/core/entities-config-editor/src/components/EntitiesConfigEditor.vue
Show resolved
Hide resolved
sumimakito
force-pushed
the
KM-1107-entities-config-editor-migrate-from-poc
branch
from
1a8a64e to
2588ed8
Compare
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
jw-foss
reviewed
Apr 15, 2025
Comment on lines
+39
to
+41
| rootSchema.properties = { | ||
| ...rootSchema.properties, | ||
| } |
There was a problem hiding this comment.
q: why are we copying this property here?
Comment on lines
+51
to
+57
| return monaco.editor.createModel(_language === 'json' ? '{}' : '', _language, uri.value) | ||
| }) | ||
|
|
||
| const textDocument = computed(() =>{ | ||
| const _language = unref(language) | ||
| return TextDocument.create(uri.value.toString(), _language, 0, _language === 'json' ? '{}' : '') | ||
| }) |
There was a problem hiding this comment.
WDYT about isolating the ternary expression into computed like:
const langTemplate = computed(() => language.value === 'json' ? '{}' : '')There was a problem hiding this comment.
Thank you for the suggestion. I'm marking this pull request as Draft for now as I plan to refactor the code a little bit. Let me come back with more improvements.
There was a problem hiding this comment.
Cool, let me know when it's ready ✉️
Comment on lines
+26
to
+28
| export interface FieldEmits<V = any> { | ||
| (e: 'update-value', value: V): void | ||
| } |
There was a problem hiding this comment.
non-blocking maybe we should use the same definition for Emitter
Suggested change
| export interface FieldEmits<V = any> { | |
| (e: 'update-value', value: V): void | |
| } | |
| export interface FieldEmits<V = any> { | |
| 'updateValue': [value: V], | |
| } |
| } | ||
|
|
||
| export const isNumberLikeField = (schema: FieldSchema): schema is NumberLikeFieldSchema => | ||
| schema.type === FIELD_TYPES.NUMBER || schema.type === FIELD_TYPES.INTEGER |
There was a problem hiding this comment.
Personally I'd prefer
Suggested change
| schema.type === FIELD_TYPES.NUMBER || schema.type === FIELD_TYPES.INTEGER | |
| [FIELD_TYPES.NUMBER, FIELD_TYPES].includes(schema.type) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request migrates the MVP from the previous PoC. The current implementation is not perfect and will be improved by future pull requests.
KM-1107