Skip to content

refactor: always enable config store for konnect #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

refactor: always enable config store for konnect #2627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/entities/entities-vaults/docs/vault-form.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ A form component for Vaults.
- *Specific to Konnect*. Show/hide Azure option.
- **Note:** This is experimental and not supported by the backend right now

- `konnectConfigStoreAvailable`
- type: `boolean`
- required: `false`
- default: `undefined`
- *Specific to Konnect*. Show/hide Konnect Config Store option.

- `ttl`
- type: `boolean`
- required: `true`
Expand Down
1 change: 0 additions & 1 deletion packages/entities/entities-vaults/sandbox/pages/VaultFormPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const konnectConfig = ref<KonnectVaultFormConfig>({
azureVaultProviderAvailable: true,
ttl: true,
hcvAppRoleMethodAvailable: true,
konnectConfigStoreAvailable: true,
conjurVaultProviderAvailable: true,
})
Expand Down
2 changes: 0 additions & 2 deletions packages/entities/entities-vaults/src/components/VaultForm.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const baseConfigKonnect: KonnectVaultFormConfig = {
apiBaseUrl: '/us/kong-api',
cancelRoute,
azureVaultProviderAvailable: false,
konnectConfigStoreAvailable: true,
ttl: true,
}

Expand All @@ -21,7 +20,6 @@ const baseConfigKonnectTurnOffTTL: KonnectVaultFormConfig = {
apiBaseUrl: '/us/kong-api',
cancelRoute,
azureVaultProviderAvailable: false,
konnectConfigStoreAvailable: true,
ttl: false,
}

Expand Down
4 changes: 2 additions & 2 deletions packages/entities/entities-vaults/src/components/VaultForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ const originalFields = reactive<VaultStateFields>({
tags: '',
})
const vaultProvider = ref<VaultProviders>(props.config.konnectConfigStoreAvailable ? VaultProviders.KONNECT : VaultProviders.ENV)
const vaultProvider = ref<VaultProviders>(props.config.app === 'konnect' ? VaultProviders.KONNECT : VaultProviders.ENV)
const originalVaultProvider = ref<VaultProviders | null>(null)
const configStoreId = ref<string>()
Expand All @@ -774,7 +774,7 @@ const isAvailableTTLConfig = computed(() => {
const providers = computed<Array<{ label: string, value: VaultProviders }>>(() => {
return [
...(
props.config.konnectConfigStoreAvailable
props.config.app === 'konnect'
? [{
label: t('form.config.konnect.label'),
value: VaultProviders.KONNECT,
Expand Down
9 changes: 3 additions & 6 deletions packages/entities/entities-vaults/src/types/vault-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,10 @@ export interface BaseVaultFormConfig extends Omit<BaseFormConfig, 'cancelRoute'>
* Show/hide cert option and corresponding fields
*/
hcvCertMethodAvailable?: boolean

/**
* Show/hide Konnect Config Store option
*/
konnectConfigStoreAvailable?: boolean
/**
* Show/hide AWS StsEndpointUrl field
*/
* Show/hide AWS StsEndpointUrl field
*/
awsStsEndpointUrlAvailable?: boolean

/**
Expand Down
Loading