Skip to content

Deprecate asClock #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deprecate asClock #558

wants to merge 2 commits into from

Conversation

hfhbd
Copy link
Contributor

@hfhbd hfhbd commented Jul 15, 2025 •
edited
Loading

kotlin.time.asClock was added in Kotlin 2.2.0: https://youtrack.jetbrains.com/issue/KT-76394/kotlin.time.TimeSource.asClock-missing

Or remove it directly if you don't plan any compatibility releases anymore.

dkhalanskyjb
dkhalanskyjb requested changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation itself is good. We'll need to wait for the library to upgrade to 2.2.0 before merging, though: who knows what Kotlin version the next release will be?

hfhbd

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfhbd @dkhalanskyjb