Skip to content

Conversation

@pan93412
Copy link
Contributor

@pan93412 pan93412 commented Oct 4, 2025

This pull request makes minor improvements to the group_join utility function and its usage in the settings embed logic. The changes enhance type flexibility and maintain code clarity.

  • Utility function improvements:

    • Changed the group_join function parameter from list[str] to Iterable[str] to allow more flexible input types. (src/utils.py)
    • Updated the initialization of the groups variable in group_join to use type hinting with list[str]() for clarity. (src/utils.py)
  • Usage update:

    • Adjusted the call to group_join in the embed method to pass a generator expression instead of a list comprehension, leveraging the new Iterable[str] parameter type. (src/settings.py)

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@pan93412
Copy link
Contributor Author

pan93412 commented Oct 4, 2025

I have read the CLA Document and I hereby sign the CLA

@Kyrela Kyrela merged commit b72aa5c into Kyrela:main Oct 11, 2025
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
@Kyrela
Copy link
Owner

Kyrela commented Oct 11, 2025

Thank you!

@pan93412 pan93412 deleted the generic-group-join branch October 11, 2025 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants