[DataMapper] Use name aliases for update and delete in datamapper #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaraslaut
force-pushed
the
fix/usage_of_alias_names
branch
2 times, most recently
from
23f96c9 to
ca74fe0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the DataMapper's Update and Delete operations were using C++ field identifiers instead of SQL column name aliases, causing failures when field names differed from their database column names.
Key Changes:
- Updated
UpdateandDeleteoperations to useFieldNameOfandFieldNameAtfor proper SQL column name resolution - Migrated from
CallOnMemberstoCallOnMembersWithoutNameto work with field indices instead of identifiers - Added comprehensive test coverage with
Personmodel using aliased column names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Lightweight/DataMapper/DataMapper.hpp | Fixed Update and Delete methods to use SQL column name aliases instead of C++ field identifiers |
| src/tests/DataMapper/NamingTests.cpp | Added Person model and CRUD test case validating proper alias usage in all operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Yaraslaut
force-pushed
the
fix/usage_of_alias_names
branch
4 times, most recently
from
84d8041 to
3ab5cb1
Compare
Yaraslaut
force-pushed
the
fix/usage_of_alias_names
branch
from
3ab5cb1 to
0d255fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #366
This was actually a bug