LibWeb/IndexedDB: Throw an InvalidStateException when handling a removed index / object store #6111
Conversation
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
lukasxcs
force-pushed
the
idbindex_throws_when_deleted
branch
from
69418f8 to
5c5ca86
Compare
This fixes a bunch of FIXME's, and passes a previously crashing subtest on WPT. https://wpt.fyi/results/IndexedDB/idbindex-rename-errors.any.html
lukasxcs
force-pushed
the
idbindex_throws_when_deleted
branch
from
5c5ca86 to
15fb854
Compare
|
The tests run into a timeout after correctly throwing an InvalidStateException for readonly transactions. Not sure why that happens. |
| // 7. Destroy store. | ||
| database->remove_object_store(*store); | ||
|
|
||
| store->mark_deleted(); |
There was a problem hiding this comment.
this suggestion might be plainly wrong, but: did you consider calling this from remove_object_store above?
There was a problem hiding this comment.
That won't compile because of forward decleration.. error: member access into incomplete type.
No idea how to fix that, though i like your idea as it adds validation to the removal per if (remove) mark_deleted()
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions! |
3 participants
This fixes a bunch of FIXME's and passes a previously crashing subtest on WPT https://wpt.fyi/results/IndexedDB/idbindex-rename-errors.any.html.