Skip to content

Conversation

@Psychpsyo
Copy link
Contributor

The corresponding WPT test was not imported since it still fails for unrelated reasons.
As it stands right now, we have no way of testing this behavior.

@Psychpsyo Psychpsyo requested a review from AtkinsSJ as a code owner September 8, 2025 12:28
@ladybird-bot
Copy link
Collaborator

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

The corresponding WPT test was not imported since it still fails
for unrelated reasons. As it stands right now, we have no way of
testing this behavior.
@Psychpsyo Psychpsyo force-pushed the vt-selector-specificity branch from 80854dd to 2d17010 Compare September 8, 2025 12:55
@Psychpsyo Psychpsyo changed the title LibWeb: Add handling for view transition pseudo-element selector specificity LibWeb: Add handling for view transition selector specificity Sep 8, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 30, 2025
if (first_is_one_of(simple_selector.pseudo_element().type(), CSS::PseudoElement::ViewTransitionGroup, CSS::PseudoElement::ViewTransitionImagePair, CSS::PseudoElement::ViewTransitionOld, CSS::PseudoElement::ViewTransitionNew) && simple_selector.pseudo_element().pt_name_selector().is_universal)
break;

// otherwise just count the number of type selectors and pseudo-elements in the selector (= C)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually a spec comment, it just doesn't look like it.

@github-actions github-actions bot removed the stale label Oct 1, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 23, 2025
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions!

@github-actions github-actions bot closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants