Add form component #5809
Open
Add form component #5809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2025
tabacitu
requested changes
Jun 10, 2025
There was a problem hiding this comment.
I love it! There are some things I don't understand in terms of how it works and code structure... but we can probably answer all that in a meeting.
In the meantime...
- What's the plan for Edit? Would it be implemented the same way, its own action, or what?
- What's the plan for InlineCreate? Do we need that still? Doesn't it do the same thing?
tabacitu
reviewed
Jun 11, 2025
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
tabacitu
requested changes
Jun 17, 2025
src/resources/views/crud/components/form/form_ajax_view.blade.php
Outdated
Show resolved
Hide resolved
src/resources/views/crud/components/form/form_ajax_view.blade.php
Outdated
Show resolved
Hide resolved
[ci skip] [skip ci]
tabacitu
reviewed
Jun 20, 2025
There was a problem hiding this comment.
We have a huge form_modal.js file now... but we still have A LOT of js in this file... why? Duplicate?
pxpm
commented
Jun 20, 2025
Comment on lines
+575
to
+577
| // we also move any modal that may come with the response to the end of the body | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| // we also move any modal that may come with the response to the end of the body | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This superseeds #5801