Use local vendor directory as consistent source for elFinder assets #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
ElFinder assets were collected from multiple places, i.e. the
vendordirectory, a GitHub archive and a CDN.This should be no issue, but could cause inconsitencies as versions are not necessarily matching.
AFTER - What is happening after this PR?
All ElFinder assets are retrieved from the vendor directory. This ensures consistency, removes external dependencies and allows updating/pinning the version by the user.
HOW
How did you achieve that, in technical terms?
Add a
@bassetDirectory(base_path('vendor/studio-42/elfinder/'), 'elfinder-vendor')directive to have a "single source of truth" for elFinder assets. Note that the entire directory has to be copied, as some part of the elfinder script uses relative urls to fetch assets, which causes issues if only individual bassets are used.Is it a breaking change or non-breaking change?
No.
How can we test the before & after?
Check the various implemented views to assert assets are loaded and correct.